IZXFER izLinkedFlowMult re support of models using zone multiplier(s) #403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nealkruis
requested changes
Jun 12, 2023
Contributor
nealkruis
left a comment
nealkruis
left a comment
There was a problem hiding this comment.
The PR title also needs to be more descriptive.
src/cgcomp.cpp
Outdated
| oa_exhAF.af_Init(); | ||
| float supVf = 0.f; | ||
| float exhVf = 0.f; | ||
| // float exhVf = 0.f; not used |
Contributor
There was a problem hiding this comment.
This should just be removed instead of commented.
Contributor
Author
There was a problem hiding this comment.
Expanded comments and retained.
doc/src/records/izxfer.md
Outdated
|
|
||
| **izLinkedFlowMult=*float*** | ||
|
|
||
| Flow multiplier TODO |
src/cgcomp.cpp
Outdated
| AIRSTATE zoneAir; | ||
| zpx->zn_GetAirStateLs( zoneAir); | ||
| float rhoX = zpx->zn_rho0ls; | ||
| // exhVf -= izx->iz_vfMin * izx->iz_linkedFlowMult; |
chipbarnaby
changed the title
nealkruis
approved these changes
Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Initial implementation of IZXFER flow multiplier scheme to support zone multiplier modeling approach.
Only DOAS air source is implemented. Interzone flow multipliers should be considered and added if needed.
Stub documentation provided.